-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to include list of popular software included in docker image #8745
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2889769
Update README to include list of popular software included in docker …
rickymagner ba040fa
Add versions and Dockerfile reminder
rickymagner 80a7e94
Add comment on finding package versions
rickymagner cafdeca
Fix typo and add extra conda comment
rickymagner 954d16f
updated -> update in comment
rickymagner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubtuntu -> ubuntu
Why are the genomics tools versions dependent on ubuntu version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a similar note about updating the README in the conda template yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a while since I've used Ubuntu desktop but thought that certain versions set upper limits on the apt repo versions, so some packages latest versions won't work on older Ubuntu releases... is that right? If not then I'm not sure where the comment could go. The apt commands install whatever latest is available at the time, so it's possible if they aren't pinned to the distro version then they could change underneath us without realizing with a new build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like something like this is happening (and versions might've already changed under us without realizing!). I made a simple ubuntu docker from 20.04 and then from 24.04 and installed
samtools
using the exact same updating commands from our Dockerfile. The earlier version installed 1.10 and the latter installed 1.19.2. So I think the apt repos are somehow pinned to the ubuntu version, but it's not clear if those could still update with the same ubuntu point release.