Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ReblockGVCF to subset AS annotations that aren't "raw" (pipe-delimited) #8771

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

ldgauthier
Copy link
Contributor

@ldgauthier ldgauthier commented Apr 11, 2024

To enable this feature, the non-Standard annotations to be subset need to be specified on the commandline with -A <AnnotationClass>

Copy link
Collaborator

@jonn-smith jonn-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this looks good and the additional long-form (read: manual) tests that I ran seem to be good.

Good to merge once tests pass.

@gatk-bot
Copy link

gatk-bot commented Apr 11, 2024

Github actions tests reported job failures from actions build 8648792151
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 17.0.6+10 8648792151.12 logs
integration 17.0.6+10 8648792151.11 logs
unit 17.0.6+10 8648792151.1 logs
integration 17.0.6+10 8648792151.0 logs

@jonn-smith jonn-smith merged commit 986cb15 into master Apr 12, 2024
17 checks passed
@jonn-smith jonn-smith deleted the ldg_reblockMoreASAnnotations branch April 12, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants