Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-430 Remove YNG status from vds #8861

Merged
merged 22 commits into from
Jun 6, 2024

Conversation

gbggrant
Copy link
Collaborator

@gbggrant gbggrant commented Jun 4, 2024

This PR Modifies the GvsCreateVDS wdl to no longer store the values for 'yng_status' in the VDS. The field is still used to calculate filtering at the genotype level, but not stored after that.

  • Example run of GvsCreateVDS here
  • Passing integratino test here

@gbggrant gbggrant marked this pull request as ready for review June 5, 2024 01:01
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad the integratino test passed!

@gbggrant gbggrant requested a review from chrisvittal June 6, 2024 18:15
@gbggrant gbggrant merged commit 8e7053f into ah_var_store Jun 6, 2024
10 of 16 checks passed
@gbggrant gbggrant deleted the gg_VS-430_RemoveYNGStatus_From_VDS branch June 6, 2024 18:19
gbggrant added a commit that referenced this pull request Jun 6, 2024
* remove the field 'yng_status' from the variant_data as_vqsr status dict of structs.
gbggrant added a commit that referenced this pull request Jun 7, 2024
* VS-430 Remove YNG status from vds (#8861)
* remove the field 'yng_status' from the variant_data as_vqsr status dict of structs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants