Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGEN pvar files not compressed [VS-1412] #8872

Merged
merged 3 commits into from
Jun 17, 2024
Merged

PGEN pvar files not compressed [VS-1412] #8872

merged 3 commits into from
Jun 17, 2024

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Jun 13, 2024

Successful run with conspicuously uncompressed pvar files here.

rsasch
rsasch reviewed Jun 14, 2024
View reviewed changes
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for this to be a parameter that defaults to uncompressed so we can make use of compressed files in the future (and with larger callsets)?

@mcovarr
Copy link
Collaborator Author

mcovarr commented Jun 14, 2024

Does it make sense for this to be a parameter that defaults to uncompressed so we can make use of compressed files in the future (and with larger callsets)?

Not requested by the ticket (and likely YAGNI IMHO)

@mcovarr mcovarr merged commit 7fcef54 into ah_var_store Jun 17, 2024
23 of 24 checks passed
@mcovarr mcovarr deleted the vs_1412_pgen_pvars_not_compressed branch June 17, 2024 16:00
mcovarr added a commit that referenced this pull request Jun 17, 2024
@mcovarr
PGEN pvar files not compressed [VS-1412] (#8872)
862e4a5
mcovarr added a commit that referenced this pull request Jun 17, 2024
@mcovarr
PGEN pvar files not compressed [VS-1412] (#8872) (#8874)
23e7493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsasch rsasch rsasch left review comments

@gbggrant gbggrant gbggrant approved these changes

@RoriCremer RoriCremer RoriCremer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcovarr @rsasch @gbggrant @RoriCremer