Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-1395 Related - Some UI Improvements for GvsCreateVATfromVDS.wdl #8881

Merged

Conversation

gbggrant
Copy link
Collaborator

@gbggrant gbggrant commented Jun 20, 2024

Related to VS-1395. On the PR to EchoCallset, Bec had a couple of minor suggestions. I folded them into that PR and am now adding them here to ah_var_store

Passing test run without a backslash on output_path here.
Passing test run with a backslash on output_path here.

@gbggrant gbggrant marked this pull request as ready for review June 21, 2024 14:01
@gbggrant gbggrant requested review from rsasch and mcovarr June 21, 2024 14:03
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@gbggrant gbggrant merged commit 0e7ada4 into ah_var_store Jun 21, 2024
16 of 18 checks passed
@gbggrant gbggrant deleted the gg_VS-1395_Have_CreateVATFromVDS_MoreGoodness branch June 21, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants