Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce components updates #135

Closed
btzr-io opened this issue Oct 24, 2019 · 1 comment
Closed

Reduce components updates #135

btzr-io opened this issue Oct 24, 2019 · 1 comment
Labels
hacktoberfest help wanted
Milestone
v2.0.0

Comments

@btzr-io
Copy link
Owner

btzr-io commented Oct 24, 2019 •
edited
Loading

We should prevent unnecessary component updates by using PureComponent or React.memo whenever is possible.

Notes

I don't think we should switch all components to PureComponents at least at once.
I suggest to just start with the simple ones, to make sure we don't break anything and that there is an actual performance benefit.

Also we we are rewriting some of them to functional components : see #136
@linsuri
Copy link

linsuri commented Oct 24, 2019

I will take this.

@linsuri linsuri mentioned this issue Oct 24, 2019
Closed
9 tasks
@btzr-io btzr-io pinned this issue Oct 25, 2019
@btzr-io btzr-io unpinned this issue Nov 1, 2019
btzr-io added a commit that referenced this issue Nov 22, 2019
@btzr-io
add animations + minor peformance improvements
7fdcd95 
fix #213

fix #220

fix #221

fix #188

some progress for #135
@btzr-io btzr-io added this to the v2.0.0 milestone Aug 5, 2022
@btzr-io btzr-io closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest help wanted
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@btzr-io @linsuri