Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed select component to functional #154

Merged
merged 5 commits into from
Oct 24, 2019
Merged

Changed select component to functional #154

merged 5 commits into from
Oct 24, 2019

Conversation

edumoreira1506
Copy link
Contributor

Refactor select component with react hooks. Related issue #136

@btzr-io
Copy link
Owner

btzr-io commented Oct 24, 2019

Looks good. please use react.memo if possible ( unless there is no actual benefit from it or it breaks the current functionality )

@edumoreira1506
Copy link
Contributor Author

Sure!

btzr-io
btzr-io requested changes Oct 24, 2019
View reviewed changes
Copy link
Owner

@btzr-io btzr-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the current changes from: b27d74c

@edumoreira1506
Copy link
Contributor Author

All the changes from b27d74c was merged!

@btzr-io btzr-io merged commit 8368e4c into btzr-io:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btzr-io btzr-io btzr-io requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edumoreira1506 @btzr-io