Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Demo to functional component #218

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Convert Demo to functional component #218

merged 1 commit into from
Nov 22, 2019

Conversation

Larissagilliane
Copy link
Contributor

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: Issue Number: #136

accesslint[bot]
accesslint bot suggested changes Nov 13, 2019
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

examples/src/components/Field/field.js Show resolved Hide resolved
examples/src/components/Field/field.js Show resolved Hide resolved
examples/src/components/Field/field.js Show resolved Hide resolved
btzr-io
btzr-io approved these changes Nov 16, 2019
View reviewed changes
Copy link
Owner

@btzr-io btzr-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll merge this after I finish some refactoring 👍

@btzr-io btzr-io merged commit 8403b0c into btzr-io:master Nov 22, 2019
@Larissagilliane Larissagilliane deleted the demoClassToFunctional branch November 27, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint AccessLint accesslint requested changes

@btzr-io btzr-io btzr-io approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Larissagilliane @btzr-io