Update login.py LoginSecure fix #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unique LoginSecure to each domain
Update login.py LoginSecure fix
|
Apologies for the two commits. I did it through the website and it's already late for me, time to sleep. Perhaps this might be useful to someone right now, hence the approach. |
|
@bukson will you merge the pr ? |
5har0varik
reviewed
Jan 20, 2024
create_cookie fix sessionid added
szcz761
suggested changes
Jan 22, 2024
| self.session.cookies.set(**community_cookie) | ||
| self.session.cookies.set(**store_cookie) | ||
| self.session.cookies.set(**store_cookie) |
There was a problem hiding this comment.
line 64: self.session.cookies.set(**store_cookie)
should be deleted
There was a problem hiding this comment.
or add store_cookie = create_cookie(name, store_cookie_dict.get(name, cookie), store_domain)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unique LoginSecure to each domain