Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wasmtime::Func to "unsplat" arguments for the async API #8732

Conversation

ssnover
Copy link
Contributor

@ssnover ssnover commented Jun 2, 2024

Related issue: #5066

@ssnover ssnover requested review from a team as code owners June 2, 2024 01:00
@ssnover ssnover requested review from alexcrichton and removed request for a team June 2, 2024 01:00
@ssnover
Copy link
Contributor Author

ssnover commented Jun 2, 2024

@pchickey tagging you as well per your request in the issue; I don't have permission to edit reviewers.

@github-actions github-actions bot added wasi Issues pertaining to WASI wasmtime:api Related to the API of the `wasmtime` crate itself labels Jun 2, 2024
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic to me thanks so much for working on this! I'm really liking how much code was moved out of the macros and I think that's working very well 👍

@alexcrichton alexcrichton added this pull request to the merge queue Jun 3, 2024
Merged via the queue into bytecodealliance:main with commit 05fe628 Jun 3, 2024
36 checks passed
@lann lann mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasi Issues pertaining to WASI wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants