Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Archiving byzcoin #53

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Archiving byzcoin #53

merged 6 commits into from
Sep 27, 2023

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Sep 14, 2023

Archiving of the byzcoin service:

  • creating docker images with a pre-initialized blockchain
  • include omniledger, ol-explorer, and columbus-united as webapps
  • add a landing page with explanations

Code review steps:

  • follow README.md to start the demo
  • go through the signup and test the other two demos
  • give feedback/create PRs on:
    • text itself (grammar, understandability)
    • how easy it is to follow the instructions
    • the description of the Troubleshooting part
  • regarding the code, only point out big mistakes that really should be cleaned up before merging. I don't expect you to go through all files added / modified, especially not those in pkg*, which are mostly copied from cothority.

Closes c4dt/TODO#324

@ineiti ineiti self-assigned this Sep 14, 2023
@ineiti ineiti force-pushed the archive branch 7 times, most recently from 590264c to 1771ef6 Compare September 20, 2023 08:40
@ineiti ineiti force-pushed the archive branch 2 times, most recently from c8398d9 to 6617064 Compare September 20, 2023 16:09
@ineiti ineiti changed the title Adding dockerfile for byzcoin Archiving byzcoin Sep 21, 2023
Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
TODO.md Outdated Show resolved Hide resolved
archive/index.html Outdated Show resolved Hide resolved
archive/index.html Outdated Show resolved Hide resolved
Copy link
Member

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works locally, LGTM

@ineiti ineiti merged commit e4e9725 into main Sep 27, 2023
1 check passed
@ineiti ineiti deleted the archive branch September 27, 2023 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants