This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Archiving byzcoin #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
590264c
to
1771ef6
Compare
c8398d9
to
6617064
Compare
PascalinDe
reviewed
Sep 21, 2023
PascalinDe
reviewed
Sep 21, 2023
PascalinDe
reviewed
Sep 21, 2023
PascalinDe
reviewed
Sep 21, 2023
PascalinDe
reviewed
Sep 21, 2023
PascalinDe
reviewed
Sep 21, 2023
PascalinDe
reviewed
Sep 21, 2023
PascalinDe
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works locally, LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archiving of the byzcoin service:
Code review steps:
Troubleshooting
partpkg*
, which are mostly copied fromcothority
.Closes c4dt/TODO#324