Skip to content

Commit

Permalink
Set the mail username optional in setup
Browse files Browse the repository at this point in the history
During the setup process email informations were asked:
  - Driver
  - Host
  - Username
  - Password

In some situations the username is not useful because the Cachet's
host may be configured to forward email to a server.

The problem is the username was required, so we had to set a username
and then update the .env file to remove it.

To fix this problem, the mail username has been set to optional in
the setup. So if someone needs a username it still can use this field,
and otherwise people can let it empty.

See: #3244
  • Loading branch information
nalysius committed Dec 28, 2018
1 parent 59df070 commit c9bc2f5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/Http/Controllers/SetupController.php
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public function postStep1()
return $input->env['mail_driver'] === 'smtp';
});

$v->sometimes(['env.mail_address', 'env.mail_username', 'env.mail_password'], 'required', function ($input) {
$v->sometimes(['env.mail_address', 'env.mail_password'], 'required', function ($input) {
return !in_array($input->env['mail_driver'], ['log', 'smtp']);
});

Expand Down

0 comments on commit c9bc2f5

Please sign in to comment.