Merge pull request #3363 from TakeMeNL/bugfix/3288

Resolve #3288
cachethq · Dec 17, 2018 · cddeac0 · cddeac0
2 parents a7789dc + 5f1dfc6
commit cddeac0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/app/Http/Controllers/Api/ComponentController.php b/app/Http/Controllers/Api/ComponentController.php
@@ -124,7 +124,7 @@ public function update(Component $component)
                 Binput::get('link'),
                 Binput::get('order'),
                 Binput::get('group_id'),
-                (bool) Binput::get('enabled'),
+                Binput::get('enabled', $component->enabled),
                 Binput::get('meta', null),
                 (bool) Binput::get('silent', false)
             ));

diff --git a/tests/Api/ComponentTest.php b/tests/Api/ComponentTest.php
@@ -174,7 +174,7 @@ public function test_can_update_component()
         ]);
 
         $response->assertStatus(200);
-        $response->assertJsonFragment(['name' => 'Foo']);
+        $response->assertJsonFragment(['name' => 'Foo', 'enabled' => $component->enabled]);
     }
 
     public function test_can_update_component_without_status_change()
@@ -190,7 +190,7 @@ public function test_can_update_component_without_status_change()
         ]);
 
         $response->assertStatus(200);
-        $response->assertJsonFragment(['name' => 'Foo']);
+        $response->assertJsonFragment(['name' => 'Foo', 'enabled' => $component->enabled]);
     }
 
     public function test_can_update_component_with_status_change()
@@ -211,7 +211,7 @@ public function test_can_update_component_with_status_change()
         ]);
 
         $response->assertStatus(200);
-        $response->assertJsonFragment(['name' => 'Foo', 'status' => 2]);
+        $response->assertJsonFragment(['name' => 'Foo', 'status' => 2, 'enabled' => $component->enabled]);
     }
 
     public function test_can_update_component_with_meta_data()
@@ -238,6 +238,7 @@ public function test_can_update_component_with_meta_data()
                 'uuid' => '172ff3fb-41f7-49d3-8bcd-f57b53627fa0',
                 'foo'  => 'bar',
             ],
+            'enabled' => $component->enabled,
         ]);
     }