Skip to content

Commit

Permalink
Fix PHP 5.6
Browse files Browse the repository at this point in the history
  • Loading branch information
@jbrooksuk
jbrooksuk committed Sep 10, 2017
1 parent 747470a commit e9d6795
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 21 deletions.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"aws/aws-sdk-php": "^3.7",
"backup-manager/laravel": "dev-master#df53f9c9d8c6be5d7a2638f45d54b8fb7bc51e2b",
"barryvdh/laravel-cors": "^0.8",
"doctrine/dbal": "~2.5",
"doctrine/dbal": "2.5.13",
"fideloper/proxy": "^3.1",
"graham-campbell/binput": "^3.5",
"graham-campbell/core": "^5.1",
Expand Down
38 changes: 18 additions & 20 deletions composer.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 comments on commit e9d6795

@VeekeeFr
Copy link
Contributor

@VeekeeFr VeekeeFr commented on e9d6795 Sep 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still found some dependencies asking for php71:

Excerpt:

  Problem 1
    - Installation request for doctrine/annotations v1.5.0 -> satisfiable by doctrine/annotations[v1.5.0].
    - doctrine/annotations v1.5.0 requires php ^7.1 -> your PHP version (5.6.31) does not satisfy that requirement.
  Problem 2
    - Installation request for doctrine/cache v1.7.1 -> satisfiable by doctrine/cache[v1.7.1].
    - doctrine/cache v1.7.1 requires php ~7.1 -> your PHP version (5.6.31) does not satisfy that requirement.
  Problem 3
    - Installation request for doctrine/collections v1.5.0 -> satisfiable by doctrine/collections[v1.5.0].
    - doctrine/collections v1.5.0 requires php ^7.1 -> your PHP version (5.6.31) does not satisfy that requirement.
  Problem 4
    - Installation request for doctrine/inflector v1.2.0 -> satisfiable by doctrine/inflector[v1.2.0].
    - doctrine/inflector v1.2.0 requires php ^7.0 -> your PHP version (5.6.31) does not satisfy that requirement.

Is this commit final or are future updates necessary ?

@jbrooksuk
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it'd fix it, but it obviously didn't... Looking at the release history, I thought pinning to this version would fix it.

@VeekeeFr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annotations 1.5.0 requires php7.
I unsuccessfully yet tried pinning to 1.4.0.

@jbrooksuk
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamCampbell any idea?

@VeekeeFr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the issue. I needed to launch the collowing commands
composer update --no-dev -o
composer install --no-dev -o

@VeekeeFr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2718

Please sign in to comment.