Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled maintenance names a random component in notification email #2153

Closed
jhamilton09 opened this issue Oct 7, 2016 · 3 comments
Closed
Assignees
Labels
Bug Bugs with Cachet Hacktoberfest
Milestone

Comments

@jhamilton09
Copy link

Before submitting your issue, please make sure that you've checked the checkboxes below.

[ X ] I am running the latest release version of Cachet.
[ X ] I am running at least PHP 5.5.9. You can check this by running php -v.
[ X ] I have ran rm -rf bootstrap/cache/*.
[ X ] I have searched to see if this issue was previously logged.

What version of Cachet? 2.3.9
What database driver? MySQL? Postgres? SQLite? MySQL
What version of PHP? 7.0.3

Expected behaviour

Scheduled maintenance email notification would not indicate an unrelated component.

Actual behaviour

Scheduled maintenance does not choose a component. However, the notification email includes a seemingly random component in the body.

Steps to reproduce

If your issue requires any specific steps to reproduce, please outline them here.

Create a few components.
Subscribe for notifications.
Create a scheduled maintenance event.
Receive email and see top of the body (first row of the table under the h1 title):
"Scheduled (random component)"
[message]
[scheduled time]

I have also seen this apply to notifications of other incidents where you can select a component but the email specifies a different component. I have not tested enough to find a pattern.

@jbrooksuk jbrooksuk added the Bug Bugs with Cachet label Oct 7, 2016
@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Oct 7, 2016
@jbrooksuk jbrooksuk self-assigned this Oct 8, 2016
@jbrooksuk
Copy link
Member

I'm tempted to rebase bab4f25 on to 2.4 so that we can get better usage from scheduled maintenance.

Regardless, I'll take a look at this now.

@jbrooksuk
Copy link
Member

jbrooksuk commented Oct 8, 2016

Wait, how are you sending components in the maintenance email? Although the email does allow for it (I don't remember why), we don't actually have the functionality to assign components to scheduled maintenance, unless you're running from another development version (perhaps the commit above?)

This is what the scheduled email looks like. Before we implement the commit I linked, I'm going to remove any code from the current maintenance email that refers to components.

@jhamilton09
Copy link
Author

I do not get to pick the component for the maintenance but the notification was still including one. It would be exactly as your email shows but after Scheduled ([Component Name]). Thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bugs with Cachet Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants