Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription possible for internal components #2520

Closed
spiritix opened this issue May 8, 2017 · 3 comments
Closed

Subscription possible for internal components #2520

spiritix opened this issue May 8, 2017 · 3 comments
Assignees
@jbrooksuk
Labels
Bug Bugs with Cachet
Milestone
v2.4

Comments

@spiritix
Copy link

spiritix commented May 8, 2017

If I click subscribe as a not logged in user, I will see all components, independently of whether they are set to "only visible to logged in users" or not. This is a privacy issue, I don't want our subscribers to see our internal components.
@jbrooksuk jbrooksuk added the Bug Bugs with Cachet label May 9, 2017
@jbrooksuk
Copy link
Member

This is definitely a bug!

What version are you using? I reckon this will need back porting to v2.3 too.

@spiritix
Copy link
Author

spiritix commented May 9, 2017

Looks like Composer somehow pulled 2.4.0-dev. Maybe it's working in the last stable version?

@jbrooksuk jbrooksuk self-assigned this Jun 24, 2017
@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jun 24, 2017
@jbrooksuk
Copy link
Member

Fixed!

JesusZapata pushed a commit to JesusZapata/Cachet that referenced this issue Jun 25, 2017
@backstroke-bot
Update from upstream repo CachetHQ/Cachet (#4)
5eaba3c 
* System status now ignores hidden groups for guests - Fixes cachethq#2577

* Fix typo

* Update deps

* Update github-markdown

* Compile assets

* Switch to using Laravel Mix. Closes cachethq#2582

* Remove gulp dependency

* Fixes Date issue with incident dates being incorrect (as only loading out the date, not the time)

* Fix a spacing issue within text

* Fixes cachethq#2579

* Check if GLOB_BRACE is defined before using it. Fixes cachethq#2586

* Add comment as to why we define GLOB_BRACE as 0

* Prevent subscibing to internal components when not logged in

Fixes cachethq#2520

* Fixes incorrect timestamp on Scheduled Maintenances

Fixes cachethq#2578

* Add missing dev dependency

* Extend BrowserKitTesting TestCase class
JesusZapata pushed a commit to JesusZapata/Cachet that referenced this issue Jun 28, 2017
@backstroke-bot
Update from upstream repo CachetHQ/Cachet (#5)
b1818e0 
* System status now ignores hidden groups for guests - Fixes cachethq#2577

* Fix typo

* Update deps

* Update github-markdown

* Compile assets

* Switch to using Laravel Mix. Closes cachethq#2582

* Remove gulp dependency

* Fixes Date issue with incident dates being incorrect (as only loading out the date, not the time)

* Fix a spacing issue within text

* Fixes cachethq#2579

* Check if GLOB_BRACE is defined before using it. Fixes cachethq#2586

* Add comment as to why we define GLOB_BRACE as 0

* Prevent subscibing to internal components when not logged in

Fixes cachethq#2520

* Fixes incorrect timestamp on Scheduled Maintenances

Fixes cachethq#2578

* Add missing dev dependency

* Extend BrowserKitTesting TestCase class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbrooksuk jbrooksuk

Labels
Bug Bugs with Cachet
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
2 participants
@jbrooksuk @spiritix