-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all emails to use Markdown views #3101
Comments
After merging #3100 , these notifications need markdown support:
|
@jbrooksuk @nstapelbroek any ideas of when this will be implemented or if I can even do this? It's basically the primary reason we cannot use it as a company, because without the consistent unsubscribe button on the emails, it's not GDPR compliant! :) |
I'm seriously cool with helping out with this work if you need! 👍 In IncidentUpdatedNotification.php return (new MailMessage())
->subject(trans('notifications.incident.update.mail.subject'))
->markdown('notifications.incident.update', [
'incident' => $this->update->incident,
'content' => $content,
'incidentName' => $this->update->incident->name,
'newStatus' => $this->update->human_status,
'unsubscribeText' => trans('cachet.subscriber.unsubscribe'),
'unsubscribeUrl' => cachet_route('subscribe.unsubscribe', $notifiable->verify_code),
'manageSubscriptionText' => trans('cachet.subscriber.manage_subscription'),
'manageSubscriptionUrl' => cachet_route('subscribe.manage', $notifiable->verify_code),
]); update.blade.php @component('mail::message')
# {{ trans('notifications.incident.update.mail.title', ['name' => $incidentName, 'new_status' => $newStatus]) }}
{{ $content }}
Thanks,<br>
{{ Config::get('setting.app_name') }}
@include('notifications.partials.subscription')
@endcomponent Update:
I haven't done the others yet, as they are less important! I'm happy to raise a pull request if you wish? |
Fixed in #3270 |
Added markdown to some emails #3101
Replaces #3015
This should be looked at as soon as #3100 is merged. It's even more important now that GDPR is live.
The text was updated successfully, but these errors were encountered: