Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise the team member commands #1995

Merged
merged 1 commit into from
Jul 22, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@

namespace CachetHQ\Cachet\Bus\Commands\User;

final class AddTeamMemberCommand
/**
* This is the add user command.
*
* @author James Brooks <[email protected]>
*/
final class AddUserCommand
{
/**
* The user username.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@

namespace CachetHQ\Cachet\Bus\Commands\User;

final class InviteTeamMemberCommand
/**
* This is the invite user command.
*
* @author James Brooks <[email protected]>
*/
final class InviteUserCommand
{
/**
* The invite emails.
Expand All @@ -30,7 +35,7 @@ final class InviteTeamMemberCommand
];

/**
* Create a new invite team member command instance.
* Create a new invite user command instance.
*
* @param string[] $emails
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,25 @@

namespace CachetHQ\Cachet\Bus\Handlers\Commands\User;

use CachetHQ\Cachet\Bus\Commands\User\AddTeamMemberCommand;
use CachetHQ\Cachet\Bus\Commands\User\AddUserCommand;
use CachetHQ\Cachet\Bus\Events\User\UserWasAddedEvent;
use CachetHQ\Cachet\Models\User;

class AddTeamMemberCommandHandler
/**
* This is the add user command handler.
*
* @author James Brooks <[email protected]>
*/
class AddUserCommandHandler
{
/**
* Handle the add team member command.
* Handle the add user command.
*
* @param \CachetHQ\Cachet\Bus\Commands\User\AddTeamMemberCommand $command
* @param \CachetHQ\Cachet\Bus\Commands\User\AddUserCommand $command
*
* @return \CachetHQ\Cachet\Models\User
*/
public function handle(AddTeamMemberCommand $command)
public function handle(AddUserCommand $command)
{
$user = User::create([
'username' => $command->username,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,25 @@

namespace CachetHQ\Cachet\Bus\Handlers\Commands\User;

use CachetHQ\Cachet\Bus\Commands\User\InviteTeamMemberCommand;
use CachetHQ\Cachet\Bus\Commands\User\InviteUserCommand;
use CachetHQ\Cachet\Bus\Events\User\UserWasInvitedEvent;
use CachetHQ\Cachet\Models\Invite;

class InviteTeamMemberCommandHandler
/**
* This is the invite user command handler.
*
* @author James Brooks <[email protected]>
*/
class InviteUserCommandHandler
{
/**
* Handle the invite team member command.
*
* @param \CachetHQ\Cachet\Bus\Commands\User\InviteTeamMemberCommand $command
* @param \CachetHQ\Cachet\Bus\Commands\User\InviteUserCommand $command
*
* @return void
*/
public function handle(InviteTeamMemberCommand $command)
public function handle(InviteUserCommand $command)
{
foreach ($command->emails as $email) {
$invite = Invite::create([
Expand Down
8 changes: 4 additions & 4 deletions app/Http/Controllers/Dashboard/TeamController.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
namespace CachetHQ\Cachet\Http\Controllers\Dashboard;

use AltThree\Validator\ValidationException;
use CachetHQ\Cachet\Bus\Commands\User\AddTeamMemberCommand;
use CachetHQ\Cachet\Bus\Commands\User\InviteTeamMemberCommand;
use CachetHQ\Cachet\Bus\Commands\User\AddUserCommand;
use CachetHQ\Cachet\Bus\Commands\User\InviteUserCommand;
use CachetHQ\Cachet\Bus\Commands\User\RemoveUserCommand;
use CachetHQ\Cachet\Models\User;
use GrahamCampbell\Binput\Facades\Binput;
Expand Down Expand Up @@ -81,7 +81,7 @@ public function showInviteTeamMemberView()
public function postAddUser()
{
try {
dispatch(new AddTeamMemberCommand(
dispatch(new AddUserCommand(
Binput::get('username'),
Binput::get('password'),
Binput::get('email'),
Expand Down Expand Up @@ -130,7 +130,7 @@ public function postUpdateUser(User $user)
public function postInviteUser()
{
try {
dispatch(new InviteTeamMemberCommand(
dispatch(new InviteUserCommand(
array_unique(array_filter((array) Binput::get('emails')))
));
} catch (ValidationException $e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@
namespace CachetHQ\Tests\Cachet\Bus\Commands\User;

use AltThree\TestBench\CommandTrait;
use CachetHQ\Cachet\Bus\Commands\User\AddTeamMemberCommand;
use CachetHQ\Cachet\Bus\Handlers\Commands\User\AddTeamMemberCommandHandler;
use CachetHQ\Cachet\Bus\Commands\User\AddUserCommand;
use CachetHQ\Cachet\Bus\Handlers\Commands\User\AddUserCommandHandler;
use CachetHQ\Tests\Cachet\AbstractTestCase;

/**
* This is the add team member command test class.
* This is the add user command test class.
*
* @author James Brooks <[email protected]>
* @author Graham Campbell <[email protected]>
*/
class AddTeamMemberCommandTest extends AbstractTestCase
class AddUserCommandTest extends AbstractTestCase
{
use CommandTrait;

Expand All @@ -35,7 +35,7 @@ protected function getObjectAndParams()
'level' => 1,
];

$object = new AddTeamMemberCommand(
$object = new AddUserCommand(
$params['username'],
$params['password'],
$params['email'],
Expand All @@ -52,6 +52,6 @@ protected function objectHasRules()

protected function getHandlerClass()
{
return AddTeamMemberCommandHandler::class;
return AddUserCommandHandler::class;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,24 @@
namespace CachetHQ\Tests\Cachet\Bus\Commands\User;

use AltThree\TestBench\CommandTrait;
use CachetHQ\Cachet\Bus\Commands\User\InviteTeamMemberCommand;
use CachetHQ\Cachet\Bus\Handlers\Commands\User\InviteTeamMemberCommandHandler;
use CachetHQ\Cachet\Bus\Commands\User\InviteUserCommand;
use CachetHQ\Cachet\Bus\Handlers\Commands\User\InviteUserCommandHandler;
use CachetHQ\Tests\Cachet\AbstractTestCase;

/**
* This is the invite team member command test class.
* This is the invite user command test class.
*
* @author Graham Campbell <[email protected]>
* @author James Brooks <[email protected]>
*/
class InviteTeamMemberCommandTest extends AbstractTestCase
class InviteUserCommandTest extends AbstractTestCase
{
use CommandTrait;

protected function getObjectAndParams()
{
$params = ['emails' => ['[email protected]']];
$object = new InviteTeamMemberCommand($params['emails']);
$object = new InviteUserCommand($params['emails']);

return compact('params', 'object');
}
Expand All @@ -40,6 +41,6 @@ protected function objectHasRules()

protected function getHandlerClass()
{
return InviteTeamMemberCommandHandler::class;
return InviteUserCommandHandler::class;
}
}