Stick incident

[sapk]

Implement #2023

work in branch : stick-incident

[jbrooksuk]

Maybe stickied is better?

[GrahamCampbell]

Might be better to use real words. "stuck"

[jbrooksuk]

Dude, "stickied" is a real word http://www.collinsdictionary.com/dictionary/english/stickied

[GrahamCampbell]

Not according to the Oxford English dictionary.

[ConnorVG]

The savageness is real.

Though I agree with @GrahamCampbell, stuck also reads better.

[GrahamCampbell]

🔥

[sapk]

Maybe a more explicite name like show(ed)_on_top or display(ed)_on_top or simply on_top ?

[ConnorVG]

Should stickied really be a bool? It'd be cool if you can, say, stick until... No? I might be over-engineering this in my head.

[sapk]

If you know exacly the date of end it maybe more a maintenance ?
Like planning for a maintenance that consist as the end of monitoring maybe.

I was more thinking of being able to show a long running problem (or task) so don't know when it will be solved and that is far away in history.

[jbrooksuk]

Should stickied really be a bool? It'd be cool if you can, say, stick until... No? I might be over-engineering this in my head.

Yeah, I'm with @sapk, that's more maintenance.

[ConnorVG]

Yeah, I clearly didn't take that into account. Apologies.

You're 100% correctamundo.

[sapk]

Ok It start to be good. Just need some information now.
So "stickied" ? And for translation I init all to the english one ?

[sapk]

I don't really know why the tests failed on PUT. I think it's maybe a init of the base incident before the update that don't have sticked member but i have not find anything on that. :-(

[ConnorVG]

Could you please make the tests pass and possibly make the definitions more consistent?

IE: https://github.com/CachetHQ/Cachet/pull/2065/files#diff-18a3c8f98774995896a403aa092a5638R115, https://github.com/CachetHQ/Cachet/pull/2065/files#diff-42a1e178504e45c7b3c2eb1207ed13e7R253, https://github.com/CachetHQ/Cachet/pull/2065/files#diff-47adb6518a63b5179a1b8476682aa9ccR78, https://github.com/CachetHQ/Cachet/pull/2065/files#diff-4053f3352543b0ef0025ff2aa1c87ce0R67

Plus, I'm unsure if stickied should really be a required parameter? Seems wise to default it to false (like in your migration). This will most likely also be the reason why the tests are failing.

[sapk]

For the consistent of definition do you mean beacause sometimes it's bool and other it's int ? I use the notify argument as a example and was thiniking that it's store as a int in db but it is a logical bool.

[ConnorVG]

Utilise the data as it's expected, not as it's stored. If it's logically interpreted as a bool, manage it that way 😄

[sapk]

Sorry for the long commit history. I am using github web ui. I know it's bad ... i will squash them tonight

[jbrooksuk]

Could you squash into one commit and rebase this please? I'll have a look then.

[sapk]

Should be ok.

[jbrooksuk]

Needs rebasing again, sorry!

[sapk]

Little merge conflict with lang change. Should be ok.

[jbrooksuk]

🎉

Thanks @sapk!