Modular Views #2069
Merged
Modular Views #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| $blade->directive('modules', function ($group = null) { | ||
| $code = [ | ||
| 'foreach (array_numeric_sort($modules) as $group => $parts) {', |
There was a problem hiding this comment.
I want this tidied and turned into a single recursive function call of some sort.
| $a = array_get($a, $key, PHP_INT_MAX); | ||
| $b = array_get($b, $key, PHP_INT_MAX); | ||
|
|
||
| $default = PHP_MAJOR_VERSION < 7 && !defined('HHVM_VERSION') ? 1 : 0; |
There was a problem hiding this comment.
We can drop the check for HHVM_VERSION.
|
Can you rebase please? |
Removed old test skip
removes hhvm check
|
That'll have to do unless you want it better. #WorkStress |
|
💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is the achieve a modular view system. I don't believe this should be part of the plugin PR.