Extracts the Dashboard routes #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks man! I'll check this later. |
| $this->app->make('CachetHQ\\Cachet\\Http\\Routes\\'.basename($file, '.php'))->map($router); | ||
| $path = app_path('Http/Routes'); | ||
|
|
||
| foreach (glob("{$path}/*{,/*}.php", GLOB_BRACE) as $file) { |
There was a problem hiding this comment.
Probably a better way to do this. I might just change it after merge.
There was a problem hiding this comment.
Yeah, I was unsure where to go on this. So I went trusty GLOB_BRACE for one/two depth routes. Would probably be nicer going finder but w/e.
There was a problem hiding this comment.
I'll probably make a small package to do this.
There was a problem hiding this comment.
While you're at it. Make your analysis test trait a package 😁
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2033