Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added placeholders #2163

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Added placeholders #2163

merged 1 commit into from
Oct 10, 2016

Conversation

abhimanyu003
Copy link
Contributor

Added placeholder to input and textareas.

@abhimanyu003
Copy link
Contributor Author

Question
Why we are not using ModelNotFoundException instead of BadRequestHttpException

https://github.com/CachetHQ/Cachet/blob/2.4/app/Http/Controllers/SignupController.php#L41-L45

I guess we can refactor this to and can use firstOrFail

Invite::where('code', '=', $code)->whereNotNull('claimed_at')->firstOrFail();

Or Even better

Invite::whereCode($code)->whereNotNull('claimed_at')->firstOrFail();

Thanks

@jbrooksuk jbrooksuk merged commit d7c1ced into cachethq:2.4 Oct 10, 2016
@jbrooksuk
Copy link
Member

@abhimanyu003 could you open an issue regarding that please?

@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abhimanyu003 @jbrooksuk