New feature: direct notify of incidents, subscribers edit in admin panel #2164

pgrabowski-wikia · 2016-10-10T14:35:16Z

Directly notifying e-mail addresses upon scheduled maintenance creation
Directly notifying e-mail addresses upon incidents update
Admin editing Subscriber e-mails and their subscriptions

pgrabowski-wikia · 2016-10-10T15:39:43Z

@jbrooksuk tests gracefully stop on my machine at 22%.
I'm on macOS Sierra
any suggestion would be much appreciated. Thank you!

[--edit--]
It seems they fail only if compiled.php is present.

$ ./vendor/bin/phpunit 
PHPUnit 4.8.21 by Sebastian Bergmann and contributors.

Runtime:    PHP 5.6.24
Configuration:  /Users/piotr/Projects/cachet/phpunit.xml

.............................................................   61 / 1102 (  5%)
.............................................................  122 / 1102 ( 11%)
.............................................................  183 / 1102 ( 16%)
.............................................................  244 / 1102 ( 22%)
...............cachet (2.4.wikia.v3) $

jbrooksuk · 2016-10-11T08:29:34Z

It'll be memory usage. You need to increase the memory_limit setting for PHP-CLI. Tests are passing here though.

pgrabowski-wikia · 2016-10-11T09:34:46Z

all done

ConnorVG · 2016-10-11T10:04:25Z

.gitignore

@@ -2,3 +2,5 @@
 node_modules
 phpunit.xml
 vendor
+.idea
+composer.lock


Could you please not modify the .gitignore?

.idea should be in your global .gitignore
composer.lock should be kept to lock down the versions people use

ConnorVG · 2016-10-11T10:04:56Z

app/Bus/Commands/Incident/ReportIncidentCommand.php

@@ -122,10 +129,11 @@
     * @param string|null $incident_date
     * @param string|null $template
     * @param array|null  $template_vars
+     * @param string      $notify_direct


This should be string|null

ConnorVG · 2016-10-11T10:05:02Z

app/Bus/Commands/Incident/ReportMaintenanceCommand.php

@@ -60,14 +67,16 @@
     * @param string $message
     * @param bool   $notify
     * @param string $timestamp
+     * @param string $directNotify


This should be string|null

ConnorVG · 2016-10-11T10:05:32Z

app/Bus/Commands/Subscriber/UpdateSubscriberCommand.php

+     * Update a new subscribe subscriber command instance.
+     *
+     * @param Subscriber $subscriber
+     * @param            $email


This is missing the param type

ConnorVG · 2016-10-11T10:05:38Z

app/Bus/Commands/Subscriber/UpdateSubscriberCommand.php

+    /**
+     * Update a new subscribe subscriber command instance.
+     *
+     * @param Subscriber $subscriber


Please only use FQN

ConnorVG · 2016-10-11T10:10:06Z

app/Http/Controllers/Dashboard/SubscriberController.php

+    /**
+     * Save the edit subscriber view.
+     *
+     * @param Subscriber $subscriber


ConnorVG · 2016-10-11T10:10:38Z

app/helpers.php

+     *
+     * @return bool
+     */
+    function direct_notifications_enabled()


I'm really unsure we actually need this

There's a subscribers_enabled() method, I though it'd be good to follow the convention.
I am fine either way

ConnorVG · 2016-10-11T10:11:00Z

config/setting.php

@@ -54,7 +66,7 @@
    |
    */

-    'show_support' => true,
+    'show_support' => false,


Please don't modify this. If you wish to change it locally, that's fine.

ConnorVG · 2016-10-11T10:11:27Z

resources/views/dashboard/incidents/add.blade.php

@@ -123,6 +123,13 @@
                        </label>
                    </div>
                    @endif
+                    @if(direct_notifications_enabled())
+                        <div class="form-group">


This doesn't need indenting

ConnorVG · 2016-10-11T10:11:47Z

resources/views/dashboard/subscribers/index.blade.php

@@ -43,6 +43,9 @@
                        @endif
                    </div>
                    <div class="col-xs-3 text-right">
+                        @if($current_user->isAdmin && subscribers_enabled())
+                            <a href="/dashboard/subscribers/{{ $subscriber->id }}/edit" class="btn btn-default">{{ trans('forms.edit') }}</a>


This doesn't need indenting

pgrabowski-wikia · 2016-10-11T11:29:01Z

CR fixed

bretterer · 2016-10-12T03:55:26Z

@pgrabowski-wikia per phpunit stopping... as soon as I set up a database, my tests started working

pgrabowski-wikia · 2016-10-12T06:20:42Z

tests are now working. I increased the php's memory and I'm running tests from within phpstorm.

ghost · 2018-06-06T12:52:27Z

Will this be possible in v3.0? --> We should be able to remove subscribers according to GDPR if they request it.

jbrooksuk · 2018-06-27T07:25:07Z

@dschwabeS11 I need to revisit this PR and look at perhaps implementing it into #3102. What do you think?

ghost · 2018-06-27T08:51:34Z

@jbrooksuk You are right. Please do! :)

jbrooksuk · 2023-08-12T19:41:30Z

Thank you for your input on Cachet 2.x. We are shifting our attention and resources to Cachet 3.x and will no longer be supporting the 2.x version. If your feedback or issue is relevant to the 3.x series, we encourage you to engage with the new branch.

For more information on the Cachet rebuild and our plans for 3.x, you can read the announcement here.

We appreciate your understanding and look forward to your contributions to the new version.

pgrabowski-wikia mentioned this pull request Oct 10, 2016

Direct User notification and subscriber editing #2144

Closed

pgrabowski-wikia force-pushed the 2.4.wikia.v3 branch 5 times, most recently from ed0e434 to 2b6c27f Compare October 11, 2016 09:30

ConnorVG suggested changes Oct 11, 2016

View reviewed changes

pgrabowski-wikia force-pushed the 2.4.wikia.v3 branch 3 times, most recently from 077d3fd to be75037 Compare October 11, 2016 11:19

New feature: direct notify of incidents, subscribers edit in admin panel

6d75e54

pgrabowski-wikia force-pushed the 2.4.wikia.v3 branch from be75037 to 6d75e54 Compare October 11, 2016 11:26

Merge branch '2.4' into 2.4.wikia.v3

ddb8c25

jbrooksuk closed this Aug 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New feature: direct notify of incidents, subscribers edit in admin panel #2164

New feature: direct notify of incidents, subscribers edit in admin panel #2164

pgrabowski-wikia commented Oct 10, 2016

pgrabowski-wikia commented Oct 10, 2016 •

edited

Loading

jbrooksuk commented Oct 11, 2016

pgrabowski-wikia commented Oct 11, 2016

ConnorVG Oct 11, 2016

ConnorVG Oct 11, 2016

ConnorVG Oct 11, 2016

ConnorVG Oct 11, 2016

ConnorVG Oct 11, 2016

ConnorVG Oct 11, 2016

ConnorVG Oct 11, 2016

pgrabowski-wikia Oct 11, 2016

ConnorVG Oct 11, 2016

ConnorVG Oct 11, 2016

ConnorVG Oct 11, 2016

pgrabowski-wikia commented Oct 11, 2016

bretterer commented Oct 12, 2016

pgrabowski-wikia commented Oct 12, 2016

ghost commented Jun 6, 2018 •

edited by ghost

Loading

jbrooksuk commented Jun 27, 2018

ghost commented Jun 27, 2018

jbrooksuk commented Aug 12, 2023

New feature: direct notify of incidents, subscribers edit in admin panel #2164

New feature: direct notify of incidents, subscribers edit in admin panel #2164

Conversation

pgrabowski-wikia commented Oct 10, 2016

pgrabowski-wikia commented Oct 10, 2016 • edited Loading

jbrooksuk commented Oct 11, 2016

pgrabowski-wikia commented Oct 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pgrabowski-wikia commented Oct 11, 2016

bretterer commented Oct 12, 2016

pgrabowski-wikia commented Oct 12, 2016

ghost commented Jun 6, 2018 • edited by ghost Loading

jbrooksuk commented Jun 27, 2018

ghost commented Jun 27, 2018

jbrooksuk commented Aug 12, 2023

pgrabowski-wikia commented Oct 10, 2016 •

edited

Loading

ghost commented Jun 6, 2018 •

edited by ghost

Loading