Change "order" condition when a component is edited #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
suggested changes
Oct 27, 2016
| @@ -66,7 +66,7 @@ | |||
| </fieldset> | |||
|
|
|||
| <input type="hidden" name="component[user_id]" value="{{ $component->agent_id || $current_user->id }}"> | |||
| <input type="hidden" name="component[order]" value="{{ $component->order || 0 }}"> | |||
| <input type="hidden" name="component[order]" value="{{ $component->order ? $component->order : 0 }}"> | |||
There was a problem hiding this comment.
should be ?: please
nicolasfagotti
force-pushed
the
componentOrderBugOnEdition
branch
from
8ecc6a5
to
1f09622
Compare
|
Change applied :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just me, or when the component order is false, the condition returns an empty value breaking the site after the update is confirmed? I had to change the way the condition is formatted for fixing the problem. Now the 0 is placed if the component order checking is false.
If this is happening on my case only, please ignore the pull request.