Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solely use Carbon #2289

Merged
merged 1 commit into from
Jan 2, 2017
Merged

Solely use Carbon #2289

merged 1 commit into from
Jan 2, 2017

Conversation

jbrooksuk
Copy link
Member

We don't need to use jenssegers/date as Carbon should be doing everything we need.

@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jan 2, 2017
@joecohens
Copy link
Contributor

Using jenssegers/date it's just because of the lang translations https://github.com/jenssegers/date#languages, it's a "wrapper" for carbon including all the translations ;)

@jbrooksuk
Copy link
Member Author

From what I can tell, Carbon has translations too?
https://github.com/briannesbitt/Carbon/tree/master/src/Carbon/Lang

@joecohens
Copy link
Contributor

😱 They added them one month ago! That's very cool, now we can safely remove the package.

@jbrooksuk
Copy link
Member Author

jbrooksuk commented Jan 2, 2017 •
edited
Loading

Happy to merge this then? I can't see why it'd stop working. I've added Carbon::setLocale too, so that should be it!

@joecohens joecohens merged commit dd11906 into 2.4 Jan 2, 2017
@joecohens joecohens deleted the only-use-carbon branch January 2, 2017 18:50
@joecohens
Copy link
Contributor

😉

@GrahamCampbell
Copy link
Contributor

Awesome to kill that unneeded library. :D

@jbrooksuk
Copy link
Member Author

Best thing is removing code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell Awaiting requested review from GrahamCampbell

Assignees

@GrahamCampbell GrahamCampbell

Labels
Refactor
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbrooksuk @joecohens @GrahamCampbell