Notifications #2295
Merged
Notifications #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2017
[ci skip] [skip ci]
jbrooksuk
force-pushed
the
new-notifications
branch
from
66eabd6
to
f03d557
Compare
|
This is ready to be merged. Although we're adding SMS and Slack, we're not actually going to add a UX setting this up until we've implemented the new design. If you want, you can go into the |
|
Just need to fix tests. |
joecohens
reviewed
Jan 4, 2017
| ->get() | ||
| ->reject(function ($subscriber) use ($notified) { | ||
| return in_array($subscriber->id, $notified); | ||
| })->map(function ($subscriber) use ($incident) { |
There was a problem hiding this comment.
I think we should use each instead of map here
joecohens
reviewed
Jan 4, 2017
| // First notify all global subscribers. | ||
| $globalSubscribers = $this->subscriber->isVerified()->isGlobal()->get(); | ||
|
|
||
| $globalSubscribers->map(function ($subscriber) use ($update) { |
joecohens
reviewed
Jan 4, 2017
| ->get() | ||
| ->reject(function ($subscriber) use ($notified) { | ||
| return in_array($subscriber->id, $notified); | ||
| })->map(function ($subscriber) use ($incident) { |
|
Done! Tests are failing but I'm sure they're unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2107, closes #1023
We're now using Laravel's Notification system, which allows us to work with Mail, Slack and Nexmo natively. Because of this, I've dropped our custom email template & views, switching to the easier template.
As a bonus, the email template is now themed based on the customisation settings.
Before this can be merged, we need a UI for setting up notifications. Also, @joecohens I don't think that unsubscribing is working?