Fix API bug and address visual bug in dashboard. #2394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly,
UpdateIncidentCommandHandler
callsUpdateComponentCommand
, however it was missing thesilent
parameter leading to incident updates to fail.Secondly, The sidebar menu currently displays incorrectly on HiDPI/Retina displays. The badge on the Scheduled Maintenance link drops down and collides with the link below
Before:
![Before](https://camo.githubusercontent.com/7c0be4cb4804aa9ce80d800e2a40d5d5ba3b6d09e3398dfe34c8eee650283ef2/687474703a2f2f75702e746d6476732e6d652f6a4e57582f64)
After:
![After](https://camo.githubusercontent.com/eaa5258ea9a22466999dc3d8eff976c956d3095ad708e11f8cbb34ff2180c546/687474703a2f2f75702e746d6476732e6d652f6a4e35622f64)