Improve metric threshold #2440
Merged
Improve metric threshold #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
suggested changes
Apr 2, 2017
app/Models/Metric.php
Outdated
| $messages = []; | ||
|
|
||
| if (60 % $this->threshold !== 0) { | ||
| $messages[] = 'Threshold must be divisible by 60.'; |
There was a problem hiding this comment.
No, the threshold must divide 60. Not the same thing.
GrahamCampbell
suggested changes
Apr 2, 2017
app/Models/Metric.php
Outdated
| @@ -221,7 +221,7 @@ public function validate() | |||
| $messages = []; | |||
|
|
|||
| if (60 % $this->threshold !== 0) { | |||
| $messages[] = 'Threshold must be divisible by 60.'; | |||
| $messages[] = 'Threshold must divide by 60.'; | |||
There was a problem hiding this comment.
Just divide 60, not by.
There was a problem hiding this comment.
Not into 60? The wording doesn't make sense haha.
There was a problem hiding this comment.
We'd say "The threshold must divide 60.", or we could notate this t | 60 for "t divides 60".
There was a problem hiding this comment.
You're a mathematician though 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2396
@GrahamCampbell and I have previous discussed this.