Trust proxies in local IPs #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows CachetHQ to be served behind proxies running in the local network.
|
It would be cool if this was something configurable via Environment variable / |
|
@djdefi Definitely! Because of this issue, I opened fideloper/TrustedProxy#81 on TrustedProxy to see if there's interest in allowing this to be configured via env variables in the library level. |
|
Looks good to me. |
|
👍 |
|
Looks good to me too, thanks for also opening the issue on TrustedProxies @vitorbaptista |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows CachetHQ to be served behind proxies
running in the local network (e.g. a Docker container).