Do not rely on GLOB_BRACE as it is not available on non-glibc based systems #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't get why the current solution doesn't work as we only use it if it's defined, which, if you're on a non-glibc system, it'll fall back to 0. |
|
The glob expression contains braces which are not expanded by the glob filter if the GLOB_BRACE flag is not set. As a result the curly braces remain in the search expression and no php files are returned. |
|
@koendc I see... The problem with your fix is that we're still limited to one sub-directory though. Although this is fine for now, long-term we may want to introduce more routes. |
|
@jbrooksuk I made the search recursive in the last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Cachet 2.4 on eg the alpine-based Docker deployment.
Fixes #2586.