Add the possibility of only displaying incidents in the timeline

[rarguelloF]

I added an option to just show incidents, no matter the distance between dates, in the timeline.

For example, if you had incidents on the days 2015-2-24, 2016-2-24, and 2017-4-12, and the app_incident_days option is set to 2, you would see in the first page, all the incidents from 2017-4-12 and 2016-2-24, and in the second page (previous one), all the incidents from 2015-2-24.

This option takes for granted the Only show days containing incidents in the timeline? option (it doesn't display days without incidents).

Screenshots

• New option in settings:

• Previous example illustrated:

Please let me know if you like this feature, or if you want me to change something in the code.

Kind regards,
Rodrigo

[jbrooksuk]

A lot of files have been changed when they don't need to be, things like translation files and .gitignore. Could you please undo some of these.

New translations also need to go to CrowdIn; https://translate.cachethq.io

[rarguelloF]

Ok, thanks for your response!

One of the changes I did on the translation files was removing the space on the [0,1] and [2,Inf] text chains, since it's currently being displayed. Do you want me to create a separate PR with this (since these are not really changes on the translations themselves)?

The .gitignore change is just adding my editor stuff, do you want me to create a different PR for this?

[rarguelloF]

@jbrooksuk I already removed the translation changes 👍

[jbrooksuk]

We don't use the Config facade here, instead we pass through a value, see how the rest are done 👍

[rarguelloF]

Done 👍

[rarguelloF]

@jbrooksuk what do you think of using the "Only show days containing incidents in the timeline?" configuration option for this behaviour?

[jbrooksuk]

@rarguelloF I much prefer it :)

[rarguelloF]

@jbrooksuk changes already done 👍

[jbrooksuk]

Looks good! Thank you.

[welcome]

Hooray! Your first Pull Request was merged, here's to many more 🚀