Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assertClassNotHasAttribute #2846

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Use assertClassNotHasAttribute #2846

merged 1 commit into from
Jan 16, 2018

Conversation

carusogabriel
Copy link
Contributor

No description provided.

@jbrooksuk
Copy link
Member

What's the benefit to this?

@carusogabriel
Copy link
Contributor Author

carusogabriel commented Jan 16, 2018 •
edited
Loading

@jbrooksuk The error message. With assertFalse:

Failed asserting that true is false.

With assertClassNotHasAttribute:

Failed asserting that class "stdClass" not has attribute "foo".

@jbrooksuk
Copy link
Member

Handy! Thanks. I've restarted Travis and it passed, so all is good.

@jbrooksuk jbrooksuk merged commit 326a3c3 into cachethq:2.4 Jan 16, 2018
@carusogabriel carusogabriel deleted the assert-class-not-has-attribute branch January 16, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carusogabriel @jbrooksuk