Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the '* optional' label behind the Component form field #2876

Merged

Conversation

nstapelbroek
Copy link
Contributor

Hi, πŸ™‹β€β™‚οΈ

This PR is a small cosmetic fix. When creating a new Incident, I noticed that the "* optional" label wasn't correctly aligned behind the label like it does when selecting the "occured_at" date. This PR should fix that.

What has been done:

From:
screenshot from 2018-01-20 23-27-02

To:
screenshot from 2018-01-20 23-28-17

How to test:

  • Make sure your Cachet is up and running.
  • Log into the dashboard and create a new incident
  • Acknowledge that the "* Optional" label of the Component field is placed below the input field
  • Checkout PR
  • Acknowledge that the "* Optional" label of the Component field is now placed besides the field label

@jbrooksuk
Copy link
Member

Much better! πŸŽ‰

@jbrooksuk jbrooksuk merged commit 7155b77 into cachethq:2.4 Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants