Adds a line in the notification email to manage its subscriptions. #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before we can accept this, we really need the text to be within the English translation files, please. |
|
I'm ok with that, do I have the rights to create that in Crowdin? |
|
It seems my rebasing/merging is wrong that's why I include more commits than needed.. I'll check why. But can I "revert" in this PR? |
|
@uxen-ab you only need to change |
|
@jbrooksuk I've used an existing translation. |
|
Can you rebase this please :) |
Untill now a subscriber wasn't able to manage its subscription because there was no link anywhere, so it was forced to unsubscribe and then subscribe again. Now the link is in the notification email, after 'Unsubscribe at'. Related to cachethq#2887
Untill now a subscriber wasn't able to manage its subscription because there was no link anywhere, so it was forced to unsubscribe and then subscribe again. Now the link is in the notification email, after 'Unsubscribe at'. Related to cachethq#2887
When a component's status changes or when an incident is created/updated, an email is sent to every people that has subscribed. At the end of the mail a link to manage its subscription has been introduced. Now, it uses the translation.
uxen-ab
force-pushed
the
subscriber-not-able-to-change-his-subscriptions-2887
branch
from
5d9f193
to
763d746
Compare
|
@jbrooksuk I have rebased it :) |
The new translation is used to manage its subscriptions.
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untill now a subscriber wasn't able to manage its subscription because
there was no link anywhere, so it was forced to unsubscribe and then
subscribe again.
Now the link is in the notification email, after 'Unsubscribe at'.
Related to #2887