Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where the redirect route is unable to resolve when rate limited #2907

Merged

Conversation

nstapelbroek
Copy link
Contributor

Buongiorno 🙋‍♂️

A small fix I found while guessing the password for my local cachet instance.

What has been done:

  • Used cachet_route to resolve the route when redirecting from the ThrottleDisplayer.

How to test:

  • Create a rate limit by trying to login
  • Acknowledge the exception message
  • Checkout PR
  • Refresh/Retry to login
  • Acknowledge you are now taken to the login page with the Rate limit exceeded. message

@jbrooksuk
Copy link
Member

Great, thanks :)

@jbrooksuk jbrooksuk merged commit e43f984 into cachethq:2.4 Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants