Don't check stylesheet with Binput #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on opening your first Pull Request, this is a momentous day for you and us! ✨
|
hensur
added a commit
to hensur/Cachet
that referenced
this pull request
Apr 18, 2018
jbrooksuk
added a commit
that referenced
this pull request
Apr 19, 2018
Backport stylesheet fix #3014 to 2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom stylesheet gets verified by Binput after the upload. This is bad because some css features are broken afterwards.
For example a data URIs get removed, see: #2453
This PR should fix this behavior by treating the stylesheet header exactly like a custom header or footer.