Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup tests #3085

Merged
merged 3 commits into from
Jun 16, 2018
Merged

Cleanup tests #3085

merged 3 commits into from
Jun 16, 2018

Conversation

jbrooksuk
Copy link
Member

@jbrooksuk jbrooksuk commented Jun 16, 2018 •
edited
Loading

  • Test names are now switched to underscore case for easier naming patterns.
  • I've removed laravel/browser-kit-testing as it's a requirement we didn't need.
  • Model factories now use the ::class notation.

Next part of this is to go through each test case and ensure we're testing for everything (#3083)

@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jun 16, 2018
@jbrooksuk jbrooksuk merged commit 8e94273 into 2.4 Jun 16, 2018
@jbrooksuk jbrooksuk deleted the cleanup-tests branch June 16, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jbrooksuk