Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how tags are created #3087

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Fix how tags are created #3087

merged 2 commits into from
Jun 18, 2018

Conversation

jbrooksuk
Copy link
Member

Fixes #3004


We now have commands that create, delete, update and apply tags. This fixes the issue where sync is not available on a ManyToMany relation.

@jbrooksuk jbrooksuk added the Bug Bugs with Cachet label Jun 16, 2018
@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jun 16, 2018
@jbrooksuk jbrooksuk requested review from GrahamCampbell and joecohens and removed request for GrahamCampbell June 16, 2018 22:04
@nalysius
Copy link
Contributor

When I test I have the following error: include(/Applications/MAMP/htdocs/Cachet/vendor/composer/../../app/Foundation/Providers/ModuleServiceProvider.php): failed to open stream: No such file or directory.

It seems this file has been removed from 2.4 too.

@jbrooksuk
Copy link
Member Author

You need to run rm -rf bootstrap/cache{,t}/*.

@nalysius
Copy link
Contributor

Indeed, manually removing cache worked. This PR worked for me!

@shuichiro-makigaki
Copy link
Contributor

Works on my side.

@jbrooksuk
Copy link
Member Author

I forgot to update the API! Just waiting for tests and then we can merge.

@jbrooksuk jbrooksuk merged commit 9eab7ce into 2.4 Jun 18, 2018
@jbrooksuk jbrooksuk deleted the tag-commands branch June 18, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bugs with Cachet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Component/tag be a ManyToMany relation?
3 participants