Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke Tests #3093

Merged
merged 3 commits into from
Jun 19, 2018
Merged

Smoke Tests #3093

merged 3 commits into from
Jun 19, 2018

Conversation

jbrooksuk
Copy link
Member

Closes #3068


Smoke tests are a simple, but useful way of testing that endpoints work, without submitting any data.

@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jun 17, 2018
@shuichiro-makigaki
Copy link
Contributor

shuichiro-makigaki commented Jun 19, 2018

In my opinion, this PR can be merged at this point even if it contains only small tests.
Because, by using this commit as skeletons, other contributors can add tests easily.
It will take a long time to make complete smoke tests, and others can/should help :)

@jbrooksuk
Copy link
Member Author

Good point, I shall merge this in later.

@jbrooksuk jbrooksuk changed the title [WIP] Smoke Tests Smoke Tests Jun 19, 2018
@jbrooksuk jbrooksuk merged commit b20461f into 2.4 Jun 19, 2018
@jbrooksuk jbrooksuk deleted the smoke-tests branch June 19, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants