-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded google2fa (0.7->5.0) #3619
Conversation
Congratulations on opening your first Pull Request, this is a momentous day for you and us! ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
Hey, thanks for opening this @MXSS. I'm unsure how I feel about requiring Imagemagick to be installed as well. Is there an alternative? |
@jbrooksuk in recent versions of used package (pragmarx/google2fa) image generation is disabled that why I had to install additional package Bacon/QRCode which requires imagick You can check package readme for more details: there's a few alternatives to that package but I'm not sure yet if we can get rid of imagick, I'll take a look |
Thanks @MXSS! GD is much easier to install and is typical of most installations that I've come across, whereas I find Imagemagick less common. |
It looks like https://github.com/chillerlan/php-qrcode has SVG support and doesn't list GD or Imagemagick as a requirement in |
removed imagick dependency Signed-off-by: Max Kovalenko <[email protected]>
@jbrooksuk done |
Nice! Could you rebase this please and we'll merge it in? |
# Conflicts: # composer.lock
Signed-off-by: Max Kovalenko <[email protected]>
Hooray! Your first Pull Request was merged, here's to many more 🚀 |
#3378