Fix timeout with large number of subscribers #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on opening your first Pull Request, this is a momentous day for you and us! ✨
|
|
Hooray! Your first Pull Request was merged, here's to many more 🚀 |
|
Thank you, I’m sure there are a few instances where we can make use of eager loading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have Cachet with 1499 subscribers, and this page was timing out. We troubleshot the issue and found this code running thousands of mysql queries and hitting the 60 second nginx timeout.
Where the template hits this inside a loop, triggering many queries:
https://github.com/CachetHQ/Cachet/blob/2.4/resources/views/dashboard/subscribers/index.blade.php#L43
Helpful page on optimizing code for ORM utilization:
https://laravel-news.com/eloquent-eager-loading