Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for undefined property in SetupController [fixes #3774] #3775

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

diegosouza
Copy link
Contributor

There is no array property named langs in SetupController. It has been broken for some time.

I've provided a fix, considering the Accept-Language request header. If it matches a locale with translations, the setup happens using them.

@welcome
Copy link

welcome bot commented Sep 8, 2019

Congratulations on opening your first Pull Request, this is a momentous day for you and us! ✨
To help us out, please make sure that you've followed the below:

@welcome
Copy link

welcome bot commented Sep 18, 2019

Hooray! Your first Pull Request was merged, here's to many more 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants