Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update threshold input name to match model #3822

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Update threshold input name to match model #3822

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb2a83d
update threshold input name to match model
craigballinger Oct 17, 2019
6a0bafe
resolve a11y label issue
craigballinger Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/views/dashboard/metrics/edit.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
</div>
<div class="form-group">
<label for="metric-places">{{ trans('forms.metrics.threshold') }}</label>
<input type="number" min="0" max="10" name="metric[threshold]" value="{{ Binput::old('metric.threshold', $metric->threshold) }}" class="form-control" required>
<input type="number" min="0" max="10" name="threshold" value="{{ Binput::old('metric.threshold', $metric->threshold) }}" class="form-control" required>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

</div>
<div class="checkbox">
<label>
Expand Down