Ignore disabled components when determining if a subscription is 'global' #4022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user updates the components he wishes to get notifications for, the 'Globally subscribed' status is set when all components are checked. When disabled components exist, Globally subscribed' is never set because the checked components are compared to the result of
Component::all()
which includes disabled components.Instead we need to compare to
Component::enabled()->get()
which will contain only the active components.