Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-463) removed dependencies: make-dir, npm and expect #464

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

nils-a
Copy link
Member

@nils-a nils-a commented Nov 24, 2020

none of which were any more in use.
Also, added depcheck as tool to report on unused dependencies.

Additionally I needed to switch from the old <> casting to the newer casting using as as depcheck otherwise interprets the code (wrongly) as tsx.

fixes #463

none of which were any more in use.
Also, added depcheck as tool to report on unused dependencies.
to the newer casting using `as`. This was done to not confuse the `tsx`
parser of `depcheck`. See depcheck/depcheck#613
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit bdf304e into cake-build:develop Nov 24, 2020
@gep13
Copy link
Member

gep13 commented Nov 24, 2020

@nils-a thanks for fixing this up!

@nils-a nils-a deleted the feature/cleanup-deps branch November 24, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dependency to npm is not needed.
2 participants