Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 14.2 support #482

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

IlyaBausovAkvelon
Copy link
Contributor

No description provided.

@DmitriyKirakosyan
Copy link

@IlyaBausovAkvelon Carthage/Build shouldn't be tracked in the repository.

@@ -75,15 +75,6 @@
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<MacroExpansion>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was it removed?

@@ -241,8 +241,8 @@ - (id) init {


LPASLLogFormatter *ASLLogFormatter = [LPASLLogFormatter new];
[[LPASLLogger sharedInstance] setLogFormatter:ASLLogFormatter];
[LPLog addLogger:[LPASLLogger sharedInstance]];
//[[LPASLLogger sharedInstance] setLogFormatter:ASLLogFormatter];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why commented?

#import <libkern/OSAtomic.h>

static NSString *const CalLogFormatterDateFormat = @"yyyy-MM-dd HH:mm:ss.SSS";
static NSString *const CalLogFormatterDateFormatterKey = @"sh.calaba.CalSSO-CalLogFormatter-NSDateFormatter";
@interface LPTTYLogFormatter () {
int32_t atomicLoggerCount;
atomic_int_fast32_t atomicLoggerCount;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you share your thoughts on this decision? why need to change old type and why it should be changed to this type?


NSArray *results = [NSArray arrayWithArray:messages];

- (NSDictionary *) JSONResponseForMethod:(NSString *) method URI:(NSString *) path data:(NSDictionary *) data {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this code removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants