Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predicate filter proposal #1075

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

Predicate filter proposal #1075

wants to merge 37 commits into from

Conversation

ark-konopacki
Copy link
Contributor

@ark-konopacki ark-konopacki commented Apr 19, 2016 •
edited
Loading

related to
#935 and #594

jmoody and others added 10 commits September 17, 2015 07:03
jmoody
jmoody reviewed Apr 24, 2016
View reviewed changes
calabash-cucumber/lib/calabash-cucumber/map.rb Outdated
end

end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's extract this to a method and add some rspec tests.

@ark-konopacki
Copy link
Contributor Author

@jmoody I moved implementation to new method and added two tests for that new method. I'm not super happy with second one since it can be false positive. Can you check?

jmoody
jmoody reviewed May 11, 2016
View reviewed changes
calabash-cucumber/spec/lib/map_spec.rb Outdated
@@ -40,5 +40,36 @@
/map view marked:'my mark', scrollToViewWithMark failed for:/)
end
end

describe ".raw_map.correct_predicate" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+100 for rspec tests.

@jmoody
Copy link
Contributor

jmoody commented May 11, 2016

There are some more test cases:

# Case insensitive matching.
LIKE[c]

# Diacritic insensitive matching
LIKE[d]

# Case and Diacritic insensitive matching
LIKE[cd]

We should have a test for those examples to ensure our /{.*}/ regex works correctly.

I think there there is also the as case that we need to handle.

There is an example of this floating around somewhere.

@ark-konopacki
Copy link
Contributor Author

@jmoody there is two methods now:
correct_predicate? check selector and if right part have two ' chars
and
correct_format? to check two ' chars in regular queries like "label marked:'label'"
Still more tests needed.

ark-konopacki and others added 2 commits May 12, 2016 22:33
@ark-konopacki
Minor fixes and adding tests
4d24fc6 
selector renamed to operation
added < and > as a valid operation
@jmoody
Merge pull request calabash#1104 from calabash/release/0.19.1
e226c3f 
Release/0.19.1
@jmoody jmoody added this to the 0.19.2 milestone May 27, 2016
@jmoody jmoody removed this from the 0.19.2 milestone Jun 29, 2016
@jmoody jmoody added this to the 0.19.3 milestone Jun 29, 2016
@jmoody jmoody modified the milestones: 0.19.3, 0.20.0 Jul 25, 2016
@jmoody jmoody modified the milestone: 0.20.0 Sep 14, 2016
@jmoody
Copy link
Contributor

jmoody commented Oct 19, 2017

Can you rebase against the latest develop?

ark-konopacki and others added 13 commits October 20, 2017 07:54
@ark-konopacki
Merge pull request #4 from calabash/develop
a267dda 
Rebase against develop
@jmoody
Merge pull request calabash#1342 from calabash/release/0.21.2
6b44569 
Release/0.21.2
@jmoody
Merge pull request calabash#1360 from calabash/release/0.21.4
ecb035f 
Release/0.21.4
@jmoody
Merge pull request calabash#1373 from calabash/release/0.21.5
ee7d0cc 
Release/0.21.5
@AlexWellsHS
Gem: bump version to 0.21.6
8a69cf1
@AlexWellsHS
update run_loop dependency version
280f23c
@AlexWellsHS
update cocoapod version
deb6224
@AlexWellsHS
remove RunLoop::SimControl methods from quit_sim, calabash_sim_reset
f72a770
@AlexWellsHS
remove SimControl reference from spec resources
4dff0a2
@AlexWellsHS
remove accessibility methods and callers
e2d974d
@AlexWellsHS
update .irbrc SimControl references to Simctl
2995a64
@jmoody
Merge pull request calabash#1389 from AlexWellsHS/release/0.21.6
603acef 
Release/0.21.6
@ark-konopacki
Merge remote-tracking branch 'upstream/master' into feature/predicate…
503e831 
…-filter-wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ark-konopacki @jmoody @AlexWellsHS