-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dark mode #15
Adding dark mode #15
Conversation
This reverts commit 48b72bc.
The missing issues of the "Codacy Static Code Analysis"-check are senseless:
What to do now? |
Fixed in #16 |
Heya, thank you for your work so far. Appreciate it! I also partly worked on dark mode (didn't push it). But since some people prefer dark mode and some light mode I would suggest adding an option to switch between both designs. But I am not sure how the settings options should be integrated tbh. Maybe you've got an idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review point for the CSS:
Could you use CSS variables for the color values. Makes changing the color values easier.
I also thought about that and simplest solution would be to adopt the operating system settings (that's how I already implemented it - these CSS rules are only activated if the OS is set to dark mode). Another idea I had, was to add a new context menu item to the tray icon, which would toggle the dark mode on and off. |
Removed the senseless checks: https://app.codacy.com/gh/callFEELD/Threema-Desktop/pullRequest?prid=7565215 Next commits will probably pass the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good!
Closes #14
Btw: The
nodejs.yml
workflow seems to be broken ...