[DPE-2728] Handle scaling to zero units #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ng-to-zero-units Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ng-to-zero-units Signed-off-by: Marcelo Henrique Neppel <[email protected]>
dragomirp
previously approved these changes
Nov 27, 2023
dragomirp
reviewed
Nov 27, 2023
| @@ -387,3 +388,43 @@ async def test_network_cut( | |||
| ), "Connection is not possible after network restore" | |||
|
|
|||
| await is_cluster_updated(ops_test, primary_name) | |||
|
|
|||
|
|
|||
| async def test_scaling_to_zero(ops_test: OpsTest, continuous_writes) -> None: | |||
There was a problem hiding this comment.
We should most probably move this test in another suite, since it's a requirement for the self healing tests to be able to run against an existing cluster and this is a potentially destructive test.
There was a problem hiding this comment.
Good point. I created https://warthogs.atlassian.net/browse/DPE-3094 to handle that.
taurus-forever
previously approved these changes
Nov 30, 2023
…ng-to-zero-units Signed-off-by: Marcelo Henrique Neppel <[email protected]>
marceloneppel
force-pushed
the
dpe-2728-handle-scaling-to-zero-units
branch
from
cecd9ae
to
c064e25
Compare
marceloneppel
dismissed stale reviews from taurus-forever and dragomirp
via
c064e25
dragomirp
approved these changes
Nov 30, 2023
taurus-forever
approved these changes
Nov 30, 2023
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
* Handle scaling to zero units Signed-off-by: Marcelo Henrique Neppel <[email protected]> * Update units tests Signed-off-by: Marcelo Henrique Neppel <[email protected]> * Remove unused constants Signed-off-by: Marcelo Henrique Neppel <[email protected]> * Don't set unknown status Signed-off-by: Marcelo Henrique Neppel <[email protected]> --------- Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the cluster is scaled to 0 units and later scaled back up again, it gets into an error state. It happens due to some conflicts in the unit data and the missing leader key in the Patroni K8S Endpoint that makes the leader unit try to get the cluster info, but it's unable to do that.
Solution
Remove unit data when scaling to zero and add the leader key back if it's missing when scaling back up again. Also, don't set Unknown in the unit status if it's the original status of the unit (otherwise it would trigger an error).
One more detail: the logic from the VM charm was copied to
src/relations/db.pyandsrc/relations/postgresql_provider.pyto avoid deleting the relation user when the PostgreSQL charm is scaled down.