Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-4227] Fix storage ownership #580

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Jul 22, 2024

Issue

If Patroni needs to reinitialise the data directory in the replicas and the storage where the data directory is created is mounted without permission for the postgres users to write on it, Patroni will fail its operation.

Solution

Fix the permissions of the data directory parent directory to enable Patroni to move/remove directories when needed.

Fixes #460.

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.86%. Comparing base (9ea09b7) to head (34f27bb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   70.92%   70.86%   -0.07%     
==========================================
  Files          10       10              
  Lines        2817     2835      +18     
  Branches      525      531       +6     
==========================================
+ Hits         1998     2009      +11     
- Misses        720      724       +4     
- Partials       99      102       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel marked this pull request as ready for review July 24, 2024 20:31
Copy link
Member

@lucasgameiroborges lucasgameiroborges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marceloneppel marceloneppel merged commit fd59ba0 into main Jul 25, 2024
84 checks passed
@marceloneppel marceloneppel deleted the dpe-4227-fix-storage-ownership branch July 25, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission denied when renaming pgdata to pgdata.failed
3 participants